Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to handling ICU-only culture names in the globalization extension project. The main focus is on ensuring that surrogate resources for these cultures are included and mapped correctly, both in the build process and in test coverage. Additionally, code formatting and organization have been improved in several files.
Resource handling and mapping enhancements:
Codebelt.Extensions.Globalization.csproj)WriteIcuNamedNlsAlternatives, inProgram.csto map ICU-only culture names to their nearest NLS equivalents and copy surrogate files accordingly, so ICU-based environments can resolve them from the same embedded resource set. (tooling/gse/Program.cs)Testing improvements:
UseNationalLanguageSupport_EnsureAllIcuCulturesAreMapped, to verify that all ICU culture names are mapped and covered by surrogate resources, improving test coverage for culture support. (CultureInfoExtensionsTest.cs)Code organization and formatting:
usingstatements for clarity. (CultureInfoExtensionsTest.cs,Program.cs) [1] [2] [3]Summary by CodeRabbit
Tests
Chores
Bug Fixes