Conversation
Replaces mutable tag/branch references with immutable SHA hashes to prevent supply chain attacks (ref: TeamPCP/Trivy March 2026). Actions left as tags: 0
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
While this PR aligns with security best practices by pinning GitHub Actions to SHAs, there are several critical issues that should prevent merging in its current state. Specifically, there is a consistent mismatch where SHAs for actions/github-script version 3.0.0 are used while the comments indicate version 2.0.0. This could introduce breaking changes if the workflows are not compatible with the v3.0.0 environment.
Furthermore, a significant logic error was detected in the workflow execution conditions in comment_issue.yml. The 'if' conditions reference step-level environment variables which are not accessible within the 'if' block's scope, causing these steps to always be skipped. Finally, the PR lacks evidence of successful workflow execution logs to verify the validity of the provided SHAs.
About this PR
- The PR lacks any verification or testing evidence (e.g., successful workflow run logs) to confirm that the provided SHAs are valid and do not break the integration.
Test suggestions
- Verify that all GitHub Actions in .github/workflows/comment_issue.yml are pinned to commit SHAs.
- Verify that all GitHub Actions in .github/workflows/create_issue.yml are pinned to commit SHAs.
- Verify that all GitHub Actions in .github/workflows/create_issue_on_label.yml are pinned to commit SHAs.
- Execute the workflows in a staging environment to ensure the specified SHAs are valid and function correctly.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that all GitHub Actions in .github/workflows/comment_issue.yml are pinned to commit SHAs.
2. Verify that all GitHub Actions in .github/workflows/create_issue.yml are pinned to commit SHAs.
3. Verify that all GitHub Actions in .github/workflows/create_issue_on_label.yml are pinned to commit SHAs.
4. Execute the workflows in a staging environment to ensure the specified SHAs are valid and function correctly.
Low confidence findings
- There is no automated linting tool (like actionlint) added to the repository to enforce this pinning policy for future changes.
🗒️ Improve review quality by adding custom instructions
| if: env.JIRA_CREATE_COMMENT_AUTO == 'true' && env.GITHUB_ISSUE_TYPE == 'issue' && env.GITHUB_ISSUE_HAS_JIRA_ISSUE_LABEL == 'true' | ||
| id: login | ||
| uses: atlassian/gajira-login@v2.0.0 | ||
| uses: atlassian/gajira-login@90a599561baaf8c05b080645ed73db7391c246ed # v2.0.0 |
There was a problem hiding this comment.
🔴 HIGH RISK
This 'if' condition will always evaluate to false because it references step-level environment variables which are not available to the 'if' key. You should use step outputs directly (e.g., 'steps.github_issue_type.outputs.result') to ensure the workflow logic functions correctly.
| - name: Add comment after sync | ||
| if: github.event.label.name == env.JIRA_ISSUE_LABEL | ||
| uses: actions/github-script@v2.0.0 | ||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 |
There was a problem hiding this comment.
🟡 MEDIUM RISK
The SHA hash refers to v3.0.0, while the comment indicates v2.0.0.
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | |
| uses: actions/github-script@083a2139045952f55ba9b2229555c2d36c2f9e4e # v2.0.0 |
| - name: Change Title | ||
| if: github.event.label.name == env.JIRA_ISSUE_LABEL | ||
| uses: actions/github-script@v2.0.0 | ||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 |
There was a problem hiding this comment.
🟡 MEDIUM RISK
The SHA hash refers to v3.0.0, while the comment indicates v2.0.0.
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | |
| uses: actions/github-script@083a2139045952f55ba9b2229555c2d36c2f9e4e # v2.0.0 |
| - name: Add comment after sync | ||
| if: env.JIRA_CREATE_ISSUE_AUTO == 'true' | ||
| uses: actions/github-script@v2.0.0 | ||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 |
There was a problem hiding this comment.
🟡 MEDIUM RISK
The SHA hash refers to v3.0.0, while the comment indicates v2.0.0.
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | |
| uses: actions/github-script@083a2139045952f55ba9b2229555c2d36c2f9e4e # v2.0.0 |
| - name: Update GitHub issue | ||
| if: env.JIRA_CREATE_ISSUE_AUTO == 'true' | ||
| uses: actions/github-script@v2.0.0 | ||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 |
There was a problem hiding this comment.
🟡 MEDIUM RISK
The SHA hash refers to v3.0.0, while the comment indicates v2.0.0.
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | |
| uses: actions/github-script@083a2139045952f55ba9b2229555c2d36c2f9e4e # v2.0.0 |
| if: env.JIRA_CREATE_COMMENT_AUTO == 'true' && env.GITHUB_ISSUE_TYPE == 'issue' && env.GITHUB_ISSUE_HAS_JIRA_ISSUE_LABEL == 'true' | ||
| id: extract_jira_number | ||
| uses: actions/github-script@v2.0.0 | ||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 |
There was a problem hiding this comment.
🟡 MEDIUM RISK
The SHA hash refers to v3.0.0, while the comment indicates v2.0.0.
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | |
| uses: actions/github-script@083a2139045952f55ba9b2229555c2d36c2f9e4e # v2.0.0 |
| if: env.JIRA_CREATE_COMMENT_AUTO == 'true' | ||
| id: github_issue_has_jira_issue_label | ||
| uses: actions/github-script@v2.0.0 | ||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 |
There was a problem hiding this comment.
🟡 MEDIUM RISK
The SHA hash refers to v3.0.0, while the comment indicates v2.0.0.
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | |
| uses: actions/github-script@083a2139045952f55ba9b2229555c2d36c2f9e4e # v2.0.0 |
| if: env.JIRA_CREATE_COMMENT_AUTO == 'true' | ||
| id: github_issue_type | ||
| uses: actions/github-script@v2.0.0 | ||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 |
There was a problem hiding this comment.
🟡 MEDIUM RISK
The SHA hash refers to v3.0.0, while the comment indicates v2.0.0. If you intended to remain on v2.0.0, use the correct SHA (083a2139045952f55ba9b2229555c2d36c2f9e4e).
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | |
| uses: actions/github-script@083a2139045952f55ba9b2229555c2d36c2f9e4e # v2.0.0 |
Pins all GitHub Actions from mutable tags/branches to immutable SHA hashes.
This prevents supply chain attacks like the TeamPCP/Trivy incident (March 2026), where attackers force-pushed tags to point at malicious commits.
Auto-generated by the Codacy security audit script.