Draft
Conversation
Split SetupWithManager into two methods for controllers with OpenStack dependencies: registerWithManager handles only the controller-runtime registration, while SetupWithManager acquires OpenStack clients first then delegates to registerWithManager. This allows integration tests to inject fake OpenStack clients and call registerWithManager directly.
Test all controllers running together in a real ctrl.Manager with envtest and fake OpenStack HTTP servers. Covers two scenarios: - SkipTests=true (fast path, ~3s) - SkipTests=false (full test VM validation, ~60s) Verifies the complete Node -> Hypervisor -> onboarding -> Ready=True flow with stateful mock handlers and catch-all failure on unhandled OpenStack requests.
…tests Add requeueInterval field to OnboardingController with getRequeueInterval() fallback to defaultWaitTime (1m) when unset. Integration test sets 1s requeue interval, reducing test runtime from ~60s to ~15s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.