Skip to content

Traits have to be applied before Aggregates#259

Merged
fwiesel merged 1 commit intomainfrom
traits_before_aggregates
Mar 11, 2026
Merged

Traits have to be applied before Aggregates#259
fwiesel merged 1 commit intomainfrom
traits_before_aggregates

Conversation

@fwiesel
Copy link
Contributor

@fwiesel fwiesel commented Mar 11, 2026

The aggregates will allow anyone to deploy to the hypervisor, but the traits define what can (or cannot) be deployed too. So, before allowing people to deploy by aggregates, we should set the correct traits.

The aggregates will allow anyone to deploy to the hypervisor,
but the traits define what can (or cannot) be deployed too.
So, before allowing people to deploy by aggregates, we should
set the correct traits.
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1 0.00% (ø)
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 61.97% (+0.47%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1/hypervisor_types.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/aggregates_controller.go 81.03% (+4.67%) 58 (+3) 47 (+5) 11 (-2) 👍
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/onboarding_controller.go 54.94% (-0.26%) 253 (+3) 139 (+1) 114 (+2) 👎
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/traits_controller.go 60.32% (+3.42%) 63 (+5) 38 (+5) 25 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/aggregates_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/onboarding_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/traits_controller_test.go

@fwiesel fwiesel merged commit 2256a06 into main Mar 11, 2026
6 checks passed
@fwiesel fwiesel deleted the traits_before_aggregates branch March 11, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants