Set TLS status condition when resource version is unchanged#68
Merged
Conversation
Ensure the TLSCertificateInstalled status condition is always set to Ready when the Secret's ResourceVersion matches the last processed version. This provides consistent status reporting even when no certificate update is needed. Also adds comprehensive unit tests covering: - Status condition set when resource version unchanged - Reconciliation skipping when InstallCertificate is false - Error handling for missing secrets and hypervisors - Version difference detection logic
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
mchristianl
approved these changes
Mar 10, 2026
fwiesel
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure the TLSCertificateInstalled status condition is always set to Ready
when the Secret's ResourceVersion matches the last processed version. This
provides consistent status reporting even when no certificate update is needed.
Also adds comprehensive unit tests covering:
Fixes nova-issues #528