feat: deprecate AlwaysNoCopyRead and remove nocopy read path#414
Merged
Conversation
AlwaysNoCopyRead no longer has any effect. The feature field is kept for backward compatibility but marked deprecated. Removed the nocopyReadMask constant, the nocopy read code path in readBinary, and all related tests. Also renamed getMode/setMode to getFlag/setFlag/unsetFlag and readonlyMask to flagUnmanaged for clarity.
xiaost
force-pushed
the
feat/rm-nocopy-read
branch
from
cadb15d to
b704448
Compare
ppzqh
approved these changes
Mar 4, 2026
YangruiEmma
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AlwaysNoCopyRead no longer has any effect. The feature field is kept for backward compatibility but marked deprecated. Removed the nocopyReadMask constant, the nocopy read code path in readBinary, and all related tests.
Also renamed getMode/setMode to getFlag/setFlag/unsetFlag and readonlyMask to flagUnmanaged for clarity.