feat: support private registries for e2e#112
Open
GabriFedi97 wants to merge 11 commits intocloudnative-pg:mainfrom
Open
feat: support private registries for e2e#112GabriFedi97 wants to merge 11 commits intocloudnative-pg:mainfrom
GabriFedi97 wants to merge 11 commits intocloudnative-pg:mainfrom
Conversation
GabriFedi97
force-pushed
the
dev/105
branch
2 times, most recently
from
f08538e to
2e3a98b
Compare
GabriFedi97
changed the title
gbartolini
reviewed
Feb 17, 2026
Contributor
Author
|
I realized there might be more convenient way to set up private credentials for e2e, which is configuring them directly in the kind nodes as docker config at path |
GabriFedi97
force-pushed
the
dev/105
branch
2 times, most recently
from
6505091 to
f2b151a
Compare
Contributor
Author
|
I confirm the new approach works fine and looks cleaner. Although the |
mbiagetti
approved these changes
Feb 23, 2026
Contributor
mbiagetti
left a comment
mbiagetti
left a comment
There was a problem hiding this comment.
LGTM
proposed also an improvement on the docs, see GabriFedi97#3
Support passing credentials for testing values generation in the dagger module. Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Support passing extra arguments to Chainsaw test execution. This way the test cmd can be customised by external callers and it can support more complex use-cases Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Matteo <matteo.biagetti@enterprisedb.com>
NiccoloFei
approved these changes
Feb 24, 2026
The cluster.yaml templates referenced a pull_secret value that was never generated, breaking all test runs. Kubelet-level credentials configured during e2e:setup-env are sufficient for private registry access. Also remove misleading --values example from EXTRA_ARGS docs. Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Only apply registry authentication when both username and password are non-empty. Prevents sending empty-credentials auth headers to public registries when no credentials are configured. Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for passing extra arguments to the Chainsaw test command exposed by the dagger module. This way, a docker-credentials secret can be created beforehand in a dedicated namespace and the same namespace can be used by Chainsaw by passing the extra args "
--namespace,<namespace>".Add also the options to pass credentials for generating Chainsaw testing values for container images hosted in private registries.
closes: #105