Fix issues in Java Main container#1234
Open
kiril-keranov wants to merge 10 commits intocloudfoundry:mainfrom
Open
Fix issues in Java Main container#1234kiril-keranov wants to merge 10 commits intocloudfoundry:mainfrom
kiril-keranov wants to merge 10 commits intocloudfoundry:mainfrom
Conversation
This reverts commit 103b123.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR addresses some flaws, issue and peculiarities of AI generated code currently present in the Java Main container. A simple java main, non spring-boot, application can be staged successfully with the current implementation with certain drawbacks and issues:
container security providerandclient certificate mapperdependencies are currently omit from the classpath when starting the java main( non spring-boot ) app. They are now added accordingly.findMainClassmarked with TODO is now addressed.profile.dscript instead of overwriting theCLASSPATHvariable that cleaned adding to toCLASSPATHby other frameworks participating in the application staging process. Also the paths to the jar dependendencies added to to the startup classpath are corrected.