fix: don't use all permissions for socket#810
Closed
justinrubek wants to merge 3 commits intocloudflare:mainfrom
Closed
fix: don't use all permissions for socket#810justinrubek wants to merge 3 commits intocloudflare:mainfrom
justinrubek wants to merge 3 commits intocloudflare:mainfrom
Conversation
Contributor
Author
|
Looks like this was pulled in commit b85f724 so this PR isn't needed anymore. It might've been useful to have an explicit update, but I finally noticed. Thanks for taking this fix! I'm happy to not have to use my forked version. |
Collaborator
Sorry, I forgot to put the accepted label on there. |
duke8253
added
the
Accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call to fchmodat for the upgrade socket was panicking in my systemd service. I had set RestrictSUIDSGID which doesn't allow for setting stat::Mode::all (which is
0o7777and sets the special bits).I believe we should only need the permission bits for the socket and not the execute bits set. This only requires
0o666(rw-rw-rw-) to function since the execute bits and special bits don't have an effect on connecting or communicating through the socket. In my testing this was sufficient to function and I was able to use RestrictSUIDSGID with the service.