Upgrade rkyv to 0.8 and remove bytecheck#24
Conversation
The rkyv 0.8 version is a major update that brings many improvements and new features. This patch adapts the API to version 0.8, removing the old API. Additionally, the key-value type in the test cases has been changed from HashMap to BTreeMap, as the data bytes of HashMap are no longer fixed in version 0.8. I suspect this is due to the unordered sorting of HashMap. After switching to BTreeMap, everything works fine.
|
@austinhartzheim Has this PR been noticed? |
|
Thanks for the contribution upgrading to Short-Term Plan: Can you confirm that this would unblock your use-case? Long-Term Plan: |
| let entity = match check_bytes { | ||
| false => archived_root::<T>(data), | ||
| true => check_archived_root::<T>(data).map_err(|_| FailedEntityRead)?, | ||
| false => access::<T::Archived, RkyvErr>(data).map_err(|_| FailedEntityRead)?, |
There was a problem hiding this comment.
Should be the other way around here.
The rkyv 0.8 version is a major update that brings many improvements and new features. This patch adapts the API to version 0.8, removing the old API.
Additionally, the key-value type in the test cases has been changed from HashMap to BTreeMap, as the data bytes of HashMap are no longer fixed in version 0.8. I suspect this is due to the unordered sorting of HashMap.
After switching to BTreeMap, everything works fine.