Bypass AlgebraicValue for datastore updates and bsatn based index scans#4311
Open
Bypass AlgebraicValue for datastore updates and bsatn based index scans#4311
AlgebraicValue for datastore updates and bsatn based index scans#4311Conversation
Centril
force-pushed
the
centril/index-bypass-av
branch
from
19f4d3e to
4c5d2b4
Compare
Centril
force-pushed
the
centril/index-bypass-av
branch
from
4c5d2b4 to
06e9145
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The commits in order do:
Deserialize for Packed, SumTagTypedIndexPointIterand fixes the naming to actually reflect what the variants are/do.UniqueMapandMultimaptoUniqueBTreeIndexandBTreeIndexrespectively.TypedIndexKeyandIndexKeyto free the table index code on its direct dependency onAlgebraicValue,allowing index scans by BSATN,
RowRefs as well without first going throughAlgebraicValue.This also has the effect of optimizing string scans by avoiding allocating in
AlgebraicValue::String.This unlocks a byte-array based future optimization for all-primitive-multi-column indexes.
Also in the future, this will enable optimizing
iter_by_col_eq, which is used by the frequent connect/disconnect logic.API and ABI breaking changes
None
Expected complexity level and risk
3? Unsafe code and very load bearing code.
Testing
Should be covered by existing tests.