Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds default values for four optional database configuration parameters (query_timeout, session_tmp_buffer, ssl, and connect_timeout) to make them truly optional. The changes update the version to 1.0.1 and simplify the README description to be more generic.
Changes:
- Added default values for
query_timeout(5000ms) andsession_tmp_buffer(128MB) in the class initialization - Added default values for
ssl('disable') andconnect_timeout(10 seconds) in the connection method - Updated version from "1.0" to "1.0.1" in pyproject.toml
- Simplified README description from "Web- / Application Servers" to just "De-Multiplexer"
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/pool.py | Added default value checks for query_timeout, session_tmp_buffer, ssl, and connect_timeout parameters |
| pyproject.toml | Bumped version from 1.0 to 1.0.1 |
| README.md | Simplified description and updated diagrams to use generic "Server Service.py" instead of "WebServer Service.py" |
|
@copilot: Please update the |
|
@clauspruefer I've opened a new pull request, #38, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: clauspruefer <17313789+clauspruefer@users.noreply.github.com>
Update CHANGELOG.md for version 1.0.1
|
@copilot Please re-update |
|
@clauspruefer I've opened a new pull request, #39, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: clauspruefer <17313789+clauspruefer@users.noreply.github.com>
Update CHANGELOG.md for version 1.0.1
Pull Request
Description
Version
1.0.1. Adds default values forquery_timeout,session_tmp_buffer,sslandconnect_timeout.The tests in example
01-logical-replicationrely on these default values and will not work otherwise (this PR also is a bug fix).Type of Change