This repository was archived by the owner on Oct 24, 2024. It is now read-only.
✨ Add a ttl option for auto expiry of deleted messages#22
Open
david-martin wants to merge 1 commit intochilts:masterfrom
Open
✨ Add a ttl option for auto expiry of deleted messages#22david-martin wants to merge 1 commit intochilts:masterfrom
david-martin wants to merge 1 commit intochilts:masterfrom
Conversation
This change allows a ttl to be set for automatically removing deleted queue messages. This can be useful for limiting the amount of space used by queues, while still maintaining some level of auditing. A new `ttl` option can be specified, in seconds, for how long before expiring a deleted message. The default is to not have any expiration i.e. the existing behaviour. Some extra assertions are added to the existing indexes test. A new test for the ttl index is also added.
Contributor
Author
|
@chilts What are your thoughts on adding this functionality? To date, I've been adding this index separately outside the module. I think it might be useful as a core function of the library. |
|
@chilts Do you have an update on if this should be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows a ttl to be set for automatically removing deleted
queue messages. This can be useful for limiting the amount of space used
by queues, while still maintaining some level of auditing.
A new
ttloption can be specified, in seconds, for how long beforeexpiring a deleted message. The default is to not have any expiration
i.e. the existing behaviour.
Some extra assertions are added to the existing indexes test.
A new test for the ttl index is also added.