GitHub Actions: migrate from nosetests to unittest#603
Merged
thiell merged 1 commit intocea-hpc:masterfrom Feb 25, 2026
Merged
Conversation
Collaborator
thiell
commented
Feb 25, 2026
thiell
commented
- Replace abandoned nose-py3 with stdlib unittest
- Update CI workflow to use 'coverage run -m unittest discover'
- Convert all test imports to package-relative imports (from .TLib import *)
- Add tests/init.py to make tests/ a proper Python package
- Fix test_027_warn_shell_globbing_nodes to handle Python 3.12 deprecation warnings
- Add 'set -euxo pipefail' to all workflow steps for better error handling
- Improve remote Python path detection using site.getsitepackages()
- Replace abandoned nose-py3 with stdlib unittest - Update CI workflow to use 'coverage run -m unittest discover' - Convert all test imports to package-relative imports (from .TLib import *) - Add tests/__init__.py to make tests/ a proper Python package - Fix test_027_warn_shell_globbing_nodes to handle Python 3.12 deprecation warnings - Add 'set -euxo pipefail' to all workflow steps for better error handling - Improve remote Python path detection using site.getsitepackages()
martinetd
approved these changes
Feb 25, 2026
Collaborator
martinetd
left a comment
martinetd
left a comment
There was a problem hiding this comment.
Thank you, tests pass and this looks good to me!
| head -2 ~/.bashrc | ||
| sed -i "2iexport PYTHONPATH=\$PYTHONPATH:$PYTHON_SITE_PACKAGES" ~/.bashrc | ||
| head -3 ~/.bashrc | ||
| ssh 127.0.0.2 'python -c "import ClusterShell; print(ClusterShell.__file__)"' |
Collaborator
There was a problem hiding this comment.
I assume this was for debugging, do we want to keep it? (ssh needs to work for tests anyway so I think it's fine to keep)
Collaborator
Author
There was a problem hiding this comment.
Exactly! I forgot to remove it. It's for troubleshooting the "remote" availability of the ClusterShell modules. But it can't hurt, I will keep it for now then.
degremont
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.