Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #690 +/- ##
=======================================
Coverage 85.08% 85.08%
=======================================
Files 85 85
Lines 4896 4896
Branches 629 629
=======================================
Hits 4166 4166
Misses 521 521
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hutch3232
left a comment
There was a problem hiding this comment.
A couple minor comments. I am a novice to the package, so my thoughts should be taken with a grain of salt. @kennethshsu asked me to provide a review.
| 5% decrease should be stated as -0.05 | ||
| date_col: str | ||
| A list-like set of effective dates corresponding to each of the changes | ||
| approximation_grain: str |
There was a problem hiding this comment.
I think typing.Literal["M", "D"] is more informative, but a change like this could wait until there is more comprehensive type hinting.
| ```bash | ||
| # Activate the environment | ||
| uv run python # or uv run jupyter-lab | ||
| uv run jupyter-lab # or uv run python |
There was a problem hiding this comment.
I don't understand this step.
$ uv run jupyter-lab
error: Failed to spawn: `jupyter-lab`
Caused by: program not foundjupyter-lab doesn't seem to exist: https://pypi.org/project/jupyter-lab/ (404). I know jupyterlab is a package, but it is not a dependency (or an extra) of chainladder-python so it won't exist in the venv.
uv run python is a decent option for starting the python REPL. My suggestion would be to provide IDE agnostic instructions. venv activation varies slightly by platform:
Linux/macOS: source .venv/bin/activate and Windows: .venv\Scripts\activate, per:
https://docs.astral.sh/uv/pip/environments/#using-a-virtual-environment
I think it can be assumed that any potential contributors already have an IDE setup or are capable of doing so.
Note
Low Risk
Low risk documentation and housekeeping changes; the only code change is a docstring clarification for
ParallelogramOLF, with no runtime logic modified.Overview
Documentation updates: clarifies
uv-based dev setup indocs/library/contributing.md, fixes theuv runexample, and updates the user guide notebook to use clearer, fully-specified multipart trend date ranges and a correctTriangle(..., cumulative=True)on-leveling example.Minor housekeeping: expands
.gitignoreto exclude Jupyter/VSCode generated artifacts (e.g.,.virtual_documents, checkpoints).Written by Cursor Bugbot for commit c861aff. This will update automatically on new commits. Configure here.