Skip to content

Comments

Clear modules table after deploying#4027

Merged
lukemelia merged 2 commits intomainfrom
cs-10218-clear-modules-table-after-deploying
Feb 20, 2026
Merged

Clear modules table after deploying#4027
lukemelia merged 2 commits intomainfrom
cs-10218-clear-modules-table-after-deploying

Conversation

@lukemelia
Copy link
Contributor

Summary

  • Adds clearAllModules() to the DefinitionLookup interface and both implementations (CachingDefinitionLookup, RealmScopedDefinitionLookup)
  • Threads definitionLookup through to the routes layer via CreateRoutesArgs
  • Calls clearAllModules() unconditionally in the post-deployment handler, after auth check but before the boxel-ui checksum comparison — ensuring stale module cache entries never persist across deployments
  • Updates both post-deployment tests to seed a modules row and verify it is cleared, proving the clear happens regardless of whether checksums differ

Test plan

  • post-deployment endpoint triggers full reindex when checksums differ — seeds modules row, verifies cleared after endpoint call
  • post-deployment endpoint clears modules cache even when checksums match — seeds modules row, verifies cleared even when no reindex occurs
  • All 4 post-deployment tests pass: NODE_ENV=test qunit --filter "post-deployment"

🤖 Generated with Claude Code

@lukemelia lukemelia changed the title CS-10218: Clear modules table after deploying Clear modules table after deploying Feb 19, 2026
@github-actions
Copy link

github-actions bot commented Feb 19, 2026

Host Test Results

    1 files  ±0      1 suites  ±0   1h 41m 33s ⏱️ - 1m 25s
1 854 tests ±0  1 840 ✅ ±0  14 💤 ±0  0 ❌ ±0 
1 869 runs  ±0  1 855 ✅ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit ea2e2b2. ± Comparison against base commit 975718c.

♻️ This comment has been updated with latest results.

The modules table caches parsed module definitions which can become stale
after deployments when server-side code changes. This adds a
clearAllModules() call to the post-deployment handler that runs before
the boxel-ui checksum comparison, ensuring stale cache entries never
persist across deployments.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@lukemelia lukemelia force-pushed the cs-10218-clear-modules-table-after-deploying branch from 28cbca0 to 138942c Compare February 19, 2026 22:44
@github-actions
Copy link

Preview deployments

@lukemelia lukemelia requested review from a team and habdelra February 20, 2026 00:40
@lukemelia lukemelia merged commit 28ee65e into main Feb 20, 2026
106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants