Skip to content

Error early when using conflicting architectures#350

Open
kraenhansen wants to merge 1 commit intomainfrom
kh/cmake-rn-error-early-on-arch-conflicts
Open

Error early when using conflicting architectures#350
kraenhansen wants to merge 1 commit intomainfrom
kh/cmake-rn-error-early-on-arch-conflicts

Conversation

@kraenhansen
Copy link
Collaborator

As a temporary workaround to fail faster and provide a better suggested fix in case a user builds both the arm64 and x86_64 slices for a simulator, I suggest adding an assertion to check for conflicting architectures before configuring the projects.

After merging this PR, running

npx cmake-rn --triplet arm64-apple-ios-sim --triplet x86_64-apple-ios-sim

will yield

✖ Failed to configure projects: Conflicting triplet variants for apple-ios-sim

ERROR Conflicting triplet variants for apple-ios-sim
FIX Remove either the arm64 or x86_64 variant of the apple-ios-sim triplet or use the universal 'arm64;x86_64-apple-ios-sim' triplet

and

npx cmake-rn --triplet arm64-apple-ios-sim --triplet 'arm64;x86_64-apple-ios-sim'

will yield

✖ Failed to configure projects: Conflicting triplet variants for apple-ios-sim

ERROR Conflicting triplet variants for apple-ios-sim
FIX Remove the arm64 variant of the apple-ios-sim triplet and use the universal 'arm64;x86_64-apple-ios-sim' triplet instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake RN Our `cmake` wrapping CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A library with the identifier 'ios-arm64_x86_64-simulator' already exists.

1 participant