Implement Option A long press for all controls#62
Merged
Conversation
- Change injection source from SOURCE_KEYBOARD to SOURCE_GAMEPAD so that KEYCODE_ENTER ACTION_DOWN is no longer routed to the IME (fixing the missing initial KEY_DOWN for the top button) and DPAD ACTION_DOWN events are no longer consumed by Android focus-navigation (fixing missing KEY_DOWN for joystick directions). - Add long press support to JoystickView and LeverView: when a direction threshold is crossed, KEY_DOWN is sent immediately and FLAG_LONG_PRESS is sent 500 ms later if the direction is still held, mirroring the existing ButtonView behaviour. https://claude.ai/code/session_01QPq7C3K71MZzKsRVGE5sac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change injection source from SOURCE_KEYBOARD to SOURCE_GAMEPAD so that KEYCODE_ENTER ACTION_DOWN is no longer routed to the IME (fixing the missing initial KEY_DOWN for the top button) and DPAD ACTION_DOWN events are no longer consumed by Android focus-navigation (fixing missing KEY_DOWN for joystick directions).
Add long press support to JoystickView and LeverView: when a direction threshold is crossed, KEY_DOWN is sent immediately and FLAG_LONG_PRESS is sent 500 ms later if the direction is still held, mirroring the existing ButtonView behaviour.