docs: make retro review test plan concrete and windows-runtime aware#571
Open
docs: make retro review test plan concrete and windows-runtime aware#571
Conversation
📦 TestPyPI package publishedpip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.12.9.dev22351743126or with uv: uv pip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.12.9.dev22351743126MCP server for Claude Codeclaude mcp add buckaroo-table -- uvx --from "buckaroo[mcp]==0.12.9.dev22351743126" --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo-table |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/loadno_browsercoercion bug and the pandasget_mode()pandas-3.0 compatibility concern have concrete reproducers and test vectors.Description
docs/retroactive-pr-review-2026-02.mdwith a detailed/loadno_browsertest matrix, explicitpytest.mark.parametrizeguidance, and recommended assertions and handler monkeypatching.get_mode()regression test cases to be added (numeric, non-numeric, NaN, empty, dtype edge cases) with file-target suggestions for unit tests.@pytest.mark.windows_smokemarker, a PR-level smoke subset to run quickly, and a scheduled/nightly blocking Windows job for broader coverage, plus guidance to expand extras smoke tests from import checks to behavior checks.Testing
sed -n '1,240p' docs/retroactive-pr-review-2026-02.md.nl -ba docs/retroactive-pr-review-2026-02.md | sed -n '1,280p'to verify content and line layout.git status --shortto confirm the file was staged for inclusion; these verification commands completed successfully.Codex Task