feat: add function that returns holidays of the year#397
Closed
vicentevendramin wants to merge 1 commit intobrazilian-utils:mainfrom
Closed
feat: add function that returns holidays of the year#397vicentevendramin wants to merge 1 commit intobrazilian-utils:mainfrom
vicentevendramin wants to merge 1 commit intobrazilian-utils:mainfrom
Conversation
Member
|
Fala @vicentevendramin tudo certinho? Cara, estou trabalhando num refactoring pra atualizar a lib como um todo, tu se importa se eu deixar esse PR aberto ate eu terminar esse refactoring? Assim que terminar, te aviso aqui (ou eu posso aplicar as mudancas) para se adequar ao novo formato, oq tu acha? |
Member
|
Incluirei como parte do refactoring #398, vou te incluir nos contributors assim que terminar. Sinta-se a vontade a fazer o code review! |
Author
|
E aí, obrigado pelo retorno @hyanmandian ! Acho muito válido, fico no aguardo do refactor da lib. Se precisar de uma ajudinha, pode contar comigo 🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementei uma função que retorna todos os feriados nacionais (é importante verificar se algum está faltando).
Criei um objeto para armazenar os feriados fixos, que são aqueles com datas específicas. Para os feriados móveis, utilizei o algoritmo de Computus para calcular a data da Páscoa, e, a partir dela, determinei as datas dos outros feriados que não possuem uma data fixa.
Se precisar de mais ajustes ou outro tom, é só avisar!
resolve #395