feat: implement filter list#124
Draft
alexzhang1030 wants to merge 4 commits intobombshell-dev:mainfrom
Draft
Conversation
|
Contributor
Author
|
/cc @natemoo-re @ulken need some suggestions 🙏 |
vsn4ik
reviewed
May 26, 2023
vsn4ik
approved these changes
May 26, 2023
vsn4ik
reviewed
May 31, 2023
Comment on lines
+48
to
+54
| if (filtered.length) { | ||
| this.options = filtered.map( | ||
| ({ item }) => this.originalOptions.find(({ value }) => value === item)! | ||
| ); | ||
| } else { | ||
| this.options = []; | ||
| } |
Contributor
There was a problem hiding this comment.
Maybe a shorter version:
Suggested change
| if (filtered.length) { | |
| this.options = filtered.map( | |
| ({ item }) => this.originalOptions.find(({ value }) => value === item)! | |
| ); | |
| } else { | |
| this.options = []; | |
| } | |
| this.options = filtered.map( | |
| ({ item }) => this.originalOptions.find(({ value }) => value === item)! | |
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick preview:
Currently stage: draft
Need some feedback and suggestions:
usage: