Skip to content

fix(fetch): reject non-null window option in Request constructor#5210

Open
HiteshShonak wants to merge 2 commits intoboa-dev:mainfrom
HiteshShonak:fix/request-window-validation
Open

fix(fetch): reject non-null window option in Request constructor#5210
HiteshShonak wants to merge 2 commits intoboa-dev:mainfrom
HiteshShonak:fix/request-window-validation

Conversation

@HiteshShonak
Copy link
Contributor

This Pull Request fixes/closes #5209.

It changes the following:

  • Add window field to RequestInit and reject any non-null value with a TypeError.
  • Add a consolidated regression test covering non-null values and confirming null is still accepted.

Testing:

cargo test -p boa_runtime request -- --nocapture

Spec reference: https://fetch.spec.whatwg.org/#dom-request

@HiteshShonak HiteshShonak requested a review from a team as a code owner March 21, 2026 10:02
Copilot AI review requested due to automatic review settings March 21, 2026 10:02
@github-actions github-actions bot added the Waiting On Review Waiting on reviews from the maintainers label Mar 21, 2026
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 21, 2026
@github-actions github-actions bot added C-Tests Issues and PRs related to the tests. C-Runtime Issues and PRs related to Boa's runtime features labels Mar 21, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Boa’s Fetch Request implementation to align with the Fetch Standard requirement that the window option must be null, and adds a regression test to ensure non-null values throw.

Changes:

  • Extend RequestInit with a window field and throw a TypeError when window is non-null.
  • Add a regression test that checks several non-null window values throw, while null is accepted.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
core/runtime/src/fetch/request.rs Adds window to RequestInit and validates it during request construction.
core/runtime/src/fetch/tests/request.rs Adds a regression test for Request constructor window option behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Mar 21, 2026

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 50,539 50,539 0
Ignored 1,426 1,426 0
Failed 998 998 0
Panics 2 2 0
Conformance 95.42% 95.42% 0.00%

Tested main commit: 58a24587890677d94618259dfaa5f257ab5ef9c9
Tested PR commit: 3e02909d88dc6e7ff1a519462743854cf8291f8f
Compare commits: 58a2458...3e02909

@codecov
Copy link

codecov bot commented Mar 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.81%. Comparing base (6ddc2b4) to head (3e02909).
⚠️ Report is 913 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5210       +/-   ##
===========================================
+ Coverage   47.24%   59.81%   +12.56%     
===========================================
  Files         476      582      +106     
  Lines       46892    63463    +16571     
===========================================
+ Hits        22154    37958    +15804     
- Misses      24738    25505      +767     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Runtime Issues and PRs related to Boa's runtime features C-Tests Issues and PRs related to the tests. Waiting On Review Waiting on reviews from the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request constructor ignores non-null window option instead of throwing

2 participants