Skip to content

fix(intl): read weekday option in DateTimeFormat constructor#5206

Merged
nekevss merged 1 commit intoboa-dev:mainfrom
Lokesh0224:datetimeformat_constructor_weekday
Mar 21, 2026
Merged

fix(intl): read weekday option in DateTimeFormat constructor#5206
nekevss merged 1 commit intoboa-dev:mainfrom
Lokesh0224:datetimeformat_constructor_weekday

Conversation

@Lokesh0224
Copy link
Contributor

weekday option was incorrectly spelled as weekDay (camelCase) in FormatOptions::try_init, causing the option getter to never be called.
So this caused three failures:

constructor-options-order.js
constructor-options-throwing-getters.js
test-option-date-time-components.js

Fix: correct the option key from "weekDay" to "weekday" per ECMA-402 §11.5.

@github-actions github-actions bot added Waiting On Review Waiting on reviews from the maintainers C-Builtins PRs and Issues related to builtins/intrinsics C-Intl Changes related to the `Intl` implementation and removed Waiting On Review Waiting on reviews from the maintainers labels Mar 21, 2026
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 21, 2026
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 50,539 50,545 +6
Ignored 1,426 1,426 0
Failed 998 992 -6
Panics 2 2 0
Conformance 95.42% 95.43% +0.01%
Fixed tests (6):
test/intl402/DateTimeFormat/test-option-date-time-components.js (previously Failed)
test/intl402/DateTimeFormat/constructor-options-order.js (previously Failed)
test/intl402/DateTimeFormat/constructor-options-throwing-getters.js (previously Failed)
test/intl402/DateTimeFormat/constructor-options-style-conflict.js (previously Failed)
test/intl402/DateTimeFormat/constructor-options-order-timedate-style.js (previously Failed)
test/intl402/DateTimeFormat/constructor-options-invalid-explicit-components.js (previously Failed)

Tested main commit: 58a24587890677d94618259dfaa5f257ab5ef9c9
Tested PR commit: 7ad8b6d295049a71a4c417852cc3672c7828ab5a
Compare commits: 58a2458...7ad8b6d

@codecov
Copy link

codecov bot commented Mar 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.80%. Comparing base (6ddc2b4) to head (7ad8b6d).
⚠️ Report is 914 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5206       +/-   ##
===========================================
+ Coverage   47.24%   59.80%   +12.56%     
===========================================
  Files         476      582      +106     
  Lines       46892    63460    +16568     
===========================================
+ Hits        22154    37955    +15801     
- Misses      24738    25505      +767     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, nice catch!

@nekevss nekevss added this pull request to the merge queue Mar 21, 2026
Merged via the queue into boa-dev:main with commit 817b6ea Mar 21, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Builtins PRs and Issues related to builtins/intrinsics C-Intl Changes related to the `Intl` implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants