feat(intl): implement Temporal.Instant.prototype.toLocaleString#5096
feat(intl): implement Temporal.Instant.prototype.toLocaleString#5096JkrishnaD wants to merge 2 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5096 +/- ##
===========================================
+ Coverage 47.24% 59.65% +12.41%
===========================================
Files 476 589 +113
Lines 46892 63473 +16581
===========================================
+ Hits 22154 37866 +15712
- Misses 24738 25607 +869 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jedel1043 this pr is just a base and waiting for the #5080 get merged as in that we get |
|
Marking as blocked on #5080 |
ceab213 to
84da348
Compare
Test262 conformance changes
Fixed tests (2):Tested main commit: |
84da348 to
fb2d992
Compare
ad81018 to
9e44160
Compare
|
Hey! Just a heads-up: my PR #5199 is already in progress and it adds the needed core logic. I've also change the signature of function you're using. It's better to wait for my merge to avoid conflicts. |
|
Hey @Vellumic thanks for the heads up. So, can you ping me when your part is done. |
This Pull Request fixes/closes #5087.
It changes the following:
thisis aTemporal.Instantobjectlocalesandoptionsarguments (previously ignored with_)to_ixdtf_string_with_provideruntilIntl.DateTimeFormatintegration is completeTODO: Update for ECMA-402 compliancecomment.Full
Intl.DateTimeFormatintegration (steps 3 & 4) is blocked on #5080, which addsformat_date_time_localeandFormatDefaults::All. Once that merges, this can be updated to use that function directly.Spec: https://tc39.es/proposal-temporal/#sec-temporal.instant.tolocalestring