Skip to content

Set upper bounds for setuptools and wheel-filename#229

Merged
matthias-bach-by merged 2 commits intoblue-yonder:masterfrom
addgene:mg/upper-bound-packages
Feb 16, 2026
Merged

Set upper bounds for setuptools and wheel-filename#229
matthias-bach-by merged 2 commits intoblue-yonder:masterfrom
addgene:mg/upper-bound-packages

Conversation

@mghantous
Copy link
Contributor

@mghantous mghantous commented Feb 10, 2026

This PR adds upper bounds to the setuptools and wheel-filename dependencies in core-requirements.txt to prevent installation of incompatible versions:

  • setuptools is capped at <82 because version 82 drops pkg_resources.
  • wheel-filename is capped at <2 because version 2 breaks imports of InvalidFilenameError and parse_wheel_filename.

Note: I have fixes to remove the upper bounds in another PR, however it failed coverage and I didn't like the fact that I still had to set an upper bound for CI (due to devpi-server's devpi-init): #228

If someone would like to take over that other PR, then by all means, please do.

Also PS: Please push latest releases to pypi! Thank you.

@coveralls
Copy link

Coverage Status

coverage: 97.512%. remained the same
when pulling 842f063 on addgene:mg/upper-bound-packages
into cd31808 on blue-yonder:master.

Copy link
Collaborator

@matthias-bach-by matthias-bach-by left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@matthias-bach-by matthias-bach-by merged commit 2598bcf into blue-yonder:master Feb 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants