fix(cms): handle missing collections dir in cron saveVersions#1025
Merged
fix(cms): handle missing collections dir in cron saveVersions#1025
Conversation
The saveVersions cron job calls listCollections() which globs for *.schema.ts files in the collections/ directory. If the directory doesn't exist (e.g. when not included in the GAE deploy bundle), tiny-glob throws an ENOENT error, causing the entire cron to fail with a 500 every minute. Return an empty array instead when the collections directory is missing.
a352b92 to
ce4002c
Compare
stevenle
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
saveVersionscron job callslistCollections()which globs for*.schema.tsfiles in thecollections/directory. If the directory doesn't exist (e.g. when not included in the GAE deploy bundle),tiny-globthrows an ENOENT error, causing the entire cron to fail with a 500 every invocation.This returns an empty array instead when the
collections/directory is missing, which is the correct behavior — if there are no collections, there are no versions to save.