Open
Conversation
- Update vite 7.1.4 → 8.0.3 in packages/root and packages/root-cms - Migrate esbuild config to oxc (jsx automatic with preact import source) - Migrate build.rollupOptions to build.rolldownOptions - Remove deprecated optimizeDeps.esbuildOptions (Rolldown replaces esbuild) - Update vitest to 4.1.2 for vite 8 peer dependency compatibility - Update @vitest/browser and @vitest/browser-playwright to 4.1.2 - Update test snapshot for new build hash https://claude.ai/code/session_01EBgUoAvR74W2Cy2mayzY5X
stevenle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the build configuration to use oxc as the JavaScript/JSX transformer instead of esbuild, and rolldown instead of rollup for bundling. These changes align with Vite 8.0.3's new defaults and modernize the build toolchain.
Key Changes
jsxandjsxImportSourceoptions to oxc's nestedjsxconfiguration withruntimeandimportSourcepropertiespackages/root/src/cli/build.tsandpackages/root/src/node/vite.tsrollupOptionsreferences withrolldownOptionsthroughout the build configurationpackages/root/src/cli/build.ts(3 build configurations)esbuildOptionsfromoptimizeDepsin vite.ts that was previously needed for TypeScript decorator supportasset-url-format.test.tsto reflect changes from the new build toolchainImplementation Details
The oxc configuration uses a nested object structure for JSX settings rather than flat properties, requiring restructuring of the configuration object. All references to rollup's configuration have been systematically replaced with rolldown equivalents while maintaining the same output configuration structure.
https://claude.ai/code/session_01EBgUoAvR74W2Cy2mayzY5X