Skip to content

Remove remember ViewModel#6618

Open
david-livefront wants to merge 1 commit intomainfrom
remove-remember-viewmodel
Open

Remove remember ViewModel#6618
david-livefront wants to merge 1 commit intomainfrom
remove-remember-viewmodel

Conversation

@david-livefront
Copy link
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR removes all the instances of remeber(viewModel) from the click listeners in the codebase. These extra remebers are no longer needed since strong skipping will handle this for us. This will simplify a lot of our UIs.

I left the remeber(viewModel) for handler classes as those still some some benefit.

@david-livefront david-livefront requested review from a team as code owners March 5, 2026 23:35
@github-actions github-actions bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:docs Change Type - Documentation t:feature Change Type - Feature Development t:llm Change Type - LLM related change (e.g. CLAUDE.md files) labels Mar 5, 2026
@david-livefront david-livefront added t:tech-debt Change Type - Tech debt and removed t:docs Change Type - Documentation t:feature Change Type - Feature Development t:llm Change Type - LLM related change (e.g. CLAUDE.md files) labels Mar 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Logo
Checkmarx One – Scan Summary & Detailse1c7f9d8-4f4c-4bce-96cf-b0208f451cc2

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 82.97297% with 126 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.25%. Comparing base (aa23d5e) to head (479d479).

Files with missing lines Patch % Lines
...n/ui/auth/feature/environment/EnvironmentScreen.kt 61.76% 13 Missing ⚠️
...tor/ui/platform/feature/settings/SettingsScreen.kt 72.97% 10 Missing ⚠️
...untconfirmation/DeleteAccountConfirmationScreen.kt 36.36% 1 Missing and 6 partials ⚠️
...i/platform/feature/settings/export/ExportScreen.kt 0.00% 7 Missing ⚠️
...den/ui/vault/feature/addedit/VaultAddEditScreen.kt 85.00% 6 Missing ⚠️
...form/feature/settings/importing/ImportingScreen.kt 0.00% 6 Missing ⚠️
.../settings/accountsecurity/AccountSecurityScreen.kt 86.84% 1 Missing and 4 partials ⚠️
...ings/autofill/blockautofill/BlockAutoFillScreen.kt 58.33% 0 Missing and 5 partials ⚠️
...en/ui/vault/feature/qrcodescan/QrCodeScanScreen.kt 28.57% 3 Missing and 2 partials ⚠️
...bitwarden/ui/auth/feature/landing/LandingScreen.kt 78.94% 0 Missing and 4 partials ⚠️
... and 28 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6618      +/-   ##
==========================================
- Coverage   85.90%   85.25%   -0.66%     
==========================================
  Files         804      973     +169     
  Lines       57370    59935    +2565     
  Branches     8307     8411     +104     
==========================================
+ Hits        49284    51095    +1811     
- Misses       5203     5924     +721     
- Partials     2883     2916      +33     
Flag Coverage Δ
app-data 17.82% <0.00%> (+0.29%) ⬆️
app-ui-auth-tools 21.11% <30.18%> (+0.23%) ⬆️
app-ui-platform 15.67% <24.96%> (+0.59%) ⬆️
app-ui-vault 26.47% <12.23%> (+0.67%) ⬆️
authenticator 6.61% <16.76%> (-0.07%) ⬇️
lib-core-network-bridge 4.27% <4.62%> (-0.02%) ⬇️
lib-data-ui 0.93% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant