fix show:none and show/scroll target documentation#3723
Open
MichaelWest22 wants to merge 2 commits intobigskysoftware:four-devfrom
Open
fix show:none and show/scroll target documentation#3723MichaelWest22 wants to merge 2 commits intobigskysoftware:four-devfrom
MichaelWest22 wants to merge 2 commits intobigskysoftware:four-devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add missing handling for show:none so that show can be disabled in hx-boost where it is set to top by default.
Update documentation to remove the old show:#id:top format that is no longer parsed in the new HCON parseConfig format we use in htmx4 that has been split out into showTarget and scrollTarget modifers to keep all modifers consistent.
Corresponding issue:
#3719
Testing
Please explain how you tested this change manually, and, if applicable, what new tests you added. If
you're making a change to just the website, you can omit this section.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded