Filter Extension Requests by Student from Enrollments Page#324
Open
alxstx wants to merge 3 commits intoberkeley-cdss:mainfrom
Open
Filter Extension Requests by Student from Enrollments Page#324alxstx wants to merge 3 commits intoberkeley-cdss:mainfrom
alxstx wants to merge 3 commits intoberkeley-cdss:mainfrom
Conversation
|
✅ @alxstx — Superconductor finished — View implementation Standing by for instructions. |
cycomachead
reviewed
Mar 11, 2026
Contributor
cycomachead
left a comment
There was a problem hiding this comment.
great, this looks good. Will want to look into the failing cuke test, but otherwise will merge soon!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds the ability for instructors to click a student's name on the Enrollments page and navigate to the Requests page with the table automatically filtered to show only that student's requests. This connects the existing controller logic (
@search_query) and JavaScript search functionality by adding the missingdata-search-queryattribute to the requests table view.Testing
@search_queryis correctly assigned fromparams[:search]and defaults tonilwhen absent.@javascript) that creates a request for a student, navigates to Enrollments as a teacher, clicks the student's name, and asserts the Requests page loads with the search filter pre-populated.Documentation
No documentation required. The feature is a UI enhancement to existing pages with no new configuration or setup needed.