Skip to content

Implement P3815 - scope_association#216

Merged
dietmarkuehl merged 4 commits intobemanproject:mainfrom
Cra3z:main
Feb 14, 2026
Merged

Implement P3815 - scope_association#216
dietmarkuehl merged 4 commits intobemanproject:mainfrom
Cra3z:main

Conversation

@Cra3z
Copy link
Contributor

@Cra3z Cra3z commented Feb 12, 2026

This PR will implement P3815 - scope_association, which represents a possible association between a sender and an async scope.

@ClausKlein
Copy link
Collaborator

Please do pip install pre-commit and use it with: pre-commit run --all

We have to modes: with and w/o CXX_MODULES!

-- Detecting CXX compile features - done
-- BEMAN_USE_STD_MODULE=OFF
-- BEMAN_USE_MODULES=ON
-- CMAKE_CXX_SCAN_FOR_MODULES=ON

Copy link
Collaborator

@ClausKlein ClausKlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please respect the existing ifdefs

@coveralls
Copy link

Coverage Status

coverage: 93.991% (+0.2%) from 93.745%
when pulling 8fa8782 on Cra3z:main
into f3dcb8f on bemanproject:main.

@Cra3z Cra3z requested a review from ClausKlein February 13, 2026 10:24
Copy link
Member

@dietmarkuehl dietmarkuehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice! Thanks!

@Cra3z
Copy link
Contributor Author

Cra3z commented Feb 14, 2026

Hi @ClausKlein, I've addressed all the requested changes.
Could you please take another look when you have time? Thanks!

@ClausKlein
Copy link
Collaborator

Hi @ClausKlein, I've addressed all the requested changes. Could you please take another look when you have time? Thanks!

I locks good to me

@dietmarkuehl dietmarkuehl merged commit 30d6bb5 into bemanproject:main Feb 14, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments