Feature/refactory install module#215
Merged
dietmarkuehl merged 6 commits intobemanproject:mainfrom Feb 14, 2026
Merged
Conversation
Add support to install multiple targets Add support named FILE_SET Add support for dependencies Only BEMAN_USE_MODULES AND BEMAN_USE_STD_MODULE should control if modules are used, even if the toolchain supports it! Add cmake/README.md file Reduce usage of CMAKE_EXPERIMENTAL_CXX_IMPORT_STD Use clang++ -print-file-name=c++/libc++.modules.json only on OSX Fix: Not all CI workflow use newest cmake version Fix: find-package-test is only useful for Release build Fix clang-tidy warnings readability-use-concise-preprocessor-directives
ClausKlein
requested review from
camio,
dietmarkuehl and
neatudarius
as code owners
ClausKlein
commented
Feb 9, 2026
| target_compile_definitions(beman.execution PUBLIC BEMAN_HAS_IMPORT_STD) | ||
| else() | ||
| message(WARNING "Missing support for CMAKE_CXX_MODULE_STD!") | ||
| target_compile_definitions(${TARGET_PREFIX} PUBLIC BEMAN_HAS_IMPORT_STD) |
Collaborator
Author
There was a problem hiding this comment.
@dietmarkuehl that is the key switch for code
dietmarkuehl
approved these changes
Feb 14, 2026
Member
dietmarkuehl
left a comment
dietmarkuehl
left a comment
There was a problem hiding this comment.
Looks good. I can't assess much of the cmake stuff fully but it seems good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://github.com/ClausKlein/execution/blob/feature/refactory-install-module/cmake/README.md for the concept and features