Handle cases with only data dependencies in pkg_tar#1044
Open
tempoz wants to merge 1 commit intobazelbuild:mainfrom
Open
Handle cases with only data dependencies in pkg_tar#1044tempoz wants to merge 1 commit intobazelbuild:mainfrom
data dependencies in pkg_tar#1044tempoz wants to merge 1 commit intobazelbuild:mainfrom
Conversation
If there is no `base_path` because there are no files, just use the empty string for the `base_file_path`.
tonyaiuto
requested changes
Mar 11, 2026
Collaborator
tonyaiuto
left a comment
There was a problem hiding this comment.
can you add a test case for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is no
base_pathbecause there are no files, just use the empty string for thebase_file_path.The use case I have for this is packaging something of the following form:
Without this fix, I get the error:
I am using version
1.2.0ofrules_pkg.