Bring testing for bzlmod vs. non-bzlmod up to date with bazel features#1029
Merged
tonyaiuto merged 1 commit intobazelbuild:mainfrom Feb 22, 2026
Merged
Bring testing for bzlmod vs. non-bzlmod up to date with bazel features#1029tonyaiuto merged 1 commit intobazelbuild:mainfrom
tonyaiuto merged 1 commit intobazelbuild:mainfrom
Conversation
Head and LTS have bzlmod enabled by default, so: - stop enabling the flag explicitly - stop calling out "bzlmod" in the test name, that is now assumed, only nobzlmod needs naming - Do the packaging test against workspace only for bazel 7 and earlier. - we probably could drop the workspace test entirely. It is essentially meaningless now
cgrindel
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring testing for bzlmod vs. non-bzlmod up to date with bazel features.
Head and LTS have bzlmod enabled by default, so:
stop enabling the flag explicitly
stop calling out "bzlmod" in the test name, that is now assumed, only nobzlmod needs naming
Do the packaging test against workspace only for bazel 7 and earlier.
This is a spin out from a followup PR to #1027. //distro:packaging_test was failing on workspace tests while using bazel 8.x. Since that seemed strange, I decided to clean this up now, to get a little better prepared for the day that
--enable_bzlmodis no longer a valid flag.