fix: use BridgeValidationError for duplicate chain adapter check#70
Open
mehmetkr-31 wants to merge 1 commit intobase:mainfrom
Open
fix: use BridgeValidationError for duplicate chain adapter check#70mehmetkr-31 wants to merge 1 commit intobase:mainfrom
mehmetkr-31 wants to merge 1 commit intobase:mainfrom
Conversation
Replace generic Error with BridgeValidationError in createBridgeClient so that consumers catching BridgeError do not miss this validation failure. All other validation paths in the SDK already use structured BridgeError subclasses. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mehmetkr-31
force-pushed
the
fix/use-BridgeValidationError-in-createBridgeClient
branch
from
f2d7d5c to
4bdea60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createBridgeClient()throws a genericErrorwhen duplicate chain adapters are registeredBridgeErrorsubclassesBridgeErrorwill miss this specific validation failurenew Error(...)withnew BridgeValidationError(...)for consistencyTest plan
bun test)bun run lint)bun run build)🤖 Generated with Claude Code