Skip to content

Add bq-stat-card and extend the component roadmap toward dashboard primitives#10

Merged
JosunLP merged 4 commits intomainfrom
copilot/refactor-existing-components
Mar 24, 2026
Merged

Add bq-stat-card and extend the component roadmap toward dashboard primitives#10
JosunLP merged 4 commits intomainfrom
copilot/refactor-existing-components

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 24, 2026

  • Inspect the new stat-card accessibility review comment and current loading-status markup
  • Update bq-stat-card loading announcement to include explicit polite live-region behavior
  • Add or update targeted test coverage for the loading status attributes
  • Run targeted validation for the stat-card follow-up
  • Run final code review/security checks and reply on the PR thread with the fix commit and screenshot

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits March 24, 2026 15:09
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bQuery/ui/sessions/01360682-98d4-484f-a913-88f2d137cdee
Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bQuery/ui/sessions/01360682-98d4-484f-a913-88f2d137cdee
@JosunLP JosunLP marked this pull request as ready for review March 24, 2026 15:16
Copilot AI review requested due to automatic review settings March 24, 2026 15:16
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new bq-stat-card dashboard primitive to the component library, wiring it into the library’s per-component entrypoints, root registration map, docs, and Storybook so it can be consumed consistently alongside existing components.

Changes:

  • Introduces bq-stat-card component implementation (props, theming tokens, loading skeleton, i18n-based loading announcement).
  • Registers the component in the root bundle (src/index.ts) and side-effect component bundle (src/components/index.ts), plus adds the component entrypoint (src/components/stat-card/index.ts).
  • Adds coverage across tests, Storybook stories, and VitePress docs/roadmap updates.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/stat-card.test.ts Adds unit coverage for registration, rendering, normalization, and loading a11y text.
stories/stat-card.stories.ts Adds Storybook stories for default/compact/loading usage.
src/index.ts Registers stat-card in the global component entry map.
src/components/stat-card/index.ts Adds per-component entrypoint export for build/modular imports.
src/components/stat-card/BqStatCard.ts Implements the new bq-stat-card component UI, styling, and a11y/i18n behavior.
src/components/index.ts Adds side-effect import to include bq-stat-card in the full bundle.
docs/guide/architecture-roadmap.md Updates roadmap language to include dashboard/summary primitives and mentions the new component.
docs/components/stat-card.md Adds documentation page for bq-stat-card API and usage.
docs/components/index.md Adds bq-stat-card to the component catalog.
docs/.vitepress/config.ts Adds Stat Card to the docs sidebar.
README.md Updates component coverage table to include Stat Card.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JosunLP
Copy link
Copy Markdown
Contributor

JosunLP commented Mar 24, 2026

@copilot apply changes based on the comments in this thread

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bQuery/ui/sessions/e73fbf15-2dc3-48ce-92fe-341ccd3a8032
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 24, 2026

@copilot apply changes based on the comments in this thread

Addressed in fc103f4.

bq-stat-card now uses per-instance ARIA ids via uniqueId() and the loading state only points aria-describedby at the rendered loading status element. I also added targeted coverage for duplicate-id prevention and loading-description wiring.

Screenshot: https://github.com/user-attachments/assets/2e1bbc31-c6bd-48f5-9794-b27cfd47f852

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JosunLP
Copy link
Copy Markdown
Contributor

JosunLP commented Mar 24, 2026

@copilot apply changes based on the comments in this thread

Co-authored-by: JosunLP <20913954+JosunLP@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bQuery/ui/sessions/12a3900c-2656-4eda-b7cb-028de4fa9f9e
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 24, 2026

@copilot apply changes based on the comments in this thread

Addressed in 8c3ddd1.

The loading status in bq-stat-card now explicitly uses aria-live="polite", and the loading-state test now verifies that attribute as part of the accessibility coverage.

Screenshot: https://github.com/user-attachments/assets/2e1bbc31-c6bd-48f5-9794-b27cfd47f852

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JosunLP JosunLP merged commit b449da9 into main Mar 24, 2026
10 checks passed
@JosunLP JosunLP deleted the copilot/refactor-existing-components branch March 24, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants