fix(dynamodb-enhanced): Fix NPE in ConverterUtils for null input#6761
Open
abhu85 wants to merge 1 commit intoaws:masterfrom
Open
fix(dynamodb-enhanced): Fix NPE in ConverterUtils for null input#6761abhu85 wants to merge 1 commit intoaws:masterfrom
abhu85 wants to merge 1 commit intoaws:masterfrom
Conversation
- Add early return for null input in validateDouble() and validateFloat()
- Fix Javadoc typo in validateFloat() ("double" → "float")
- Add comprehensive test coverage for null, valid, NaN, and infinite values
Fixes aws#6639
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a NullPointerException bug in the DynamoDB Enhanced Client where
ConverterUtils.validateDouble()andvalidateFloat()throw NPE when the input isnulldue to auto-unboxing before the null check.Root Cause
The
validateDoubleandvalidateFloatmethods usedDouble.isNaN(input)andDouble.isFinite(input)which auto-unbox theDouble/Floatwrapper to a primitive, causing NPE when input isnull.Changes
validateDouble()andvalidateFloat()validateFloat()("double" → "float")Test Plan
ConverterUtilsTesttests passTest Command
./mvnw test -pl services-custom/dynamodb-enhanced -Dtest=ConverterUtilsTestFixes #6639
Split from #6745 per maintainer request.