Add keepalive to responseInputStream timeout scheduler executor to ma…#6756
Open
Add keepalive to responseInputStream timeout scheduler executor to ma…#6756
Conversation
…ke sure scheduler thread doenst leak
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Addresses: #6567
Background and context
ResponseInputStreamuses a staticScheduledExecutorServiceto abort streams that aren't read within 60 seconds (to prevent connection leaks). The executor's thread never terminates because core threads are kept alive indefinitely by default. This causes theresponse-input-stream-timeout-schedulerthread to persist for the lifetime of the JVM, even when no streams exist.To fix this, we can set
allowCoreThreadTimeOut(true)and a 60s keep-alive on the executor. The thread now dies after 60 seconds of idleness and respawns on demand (matchesTransferManagerConfiguration.java).Testing
Since there is a timeout and a keep alive mechanism it's hard to write a deterministic test to prove the fix works. Additionally, adding a test with a sleep method of >1min is not feasible.
The following test fails on Master, and passes after the code change introduced in the PR: