Skip to content

Change integ test to use assumerole#6753

Open
RanVaknin wants to merge 3 commits intomasterfrom
rvaknin/fix-integtest-buildspec
Open

Change integ test to use assumerole#6753
RanVaknin wants to merge 3 commits intomasterfrom
rvaknin/fix-integtest-buildspec

Conversation

@RanVaknin
Copy link
Contributor

Changing the integ test buildspec to assume a cross account role to provision resources and run integ tests.
The new buildspec writes assume role into an INI config file in memory, which then the SDK integ test clients use to automatically refresh credentials.

Some tests are disabled because the specific service / operation they test is no longer supported on new accounts (essentially EOL).

  • Disabled selectObjectContent tests - this failed with a 405 despite having the right permissions. The only explanation I was able to find is this RE:post response mentioning access to select was cut off for newer accounts.
  • Disabled DataPipeline tests - access to this service was cut off. Blogpost

@RanVaknin RanVaknin requested a review from a team as a code owner February 26, 2026 08:20
@RanVaknin RanVaknin changed the title Rvaknin/fix integtest buildspec Change integ test to use assumerole Feb 26, 2026
@RanVaknin RanVaknin added no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required changelog-not-required Indicate changelog entry is not required for a specific PR labels Feb 26, 2026
@RanVaknin RanVaknin force-pushed the rvaknin/fix-integtest-buildspec branch from 6f169cb to a3df737 Compare February 26, 2026 08:30
@RanVaknin
Copy link
Contributor Author

Question:
currently I have some tests disabled because end of support for new accounts. In theory customers might still be using them. Do we need to run these separately from an older account? Or the exact opposite is true, instead of disabling them should I remove them completely?

@@ -81,6 +82,7 @@ public static void teardown() {
}
}

@Disabled("S3 Select not supported for new accounts")
Copy link
Contributor

@dagnir dagnir Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker but let's add a TODO + backlog item to move these to wiremock tests.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
34.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-not-required Indicate changelog entry is not required for a specific PR no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants