Skip to content

Changed order of method calls in ProfileCredentialsProvider resolveCredentials method#5624

Open
piotr-goetz-duco wants to merge 1 commit intoaws:masterfrom
piotr-goetz-duco:credentials-resolve-fix
Open

Changed order of method calls in ProfileCredentialsProvider resolveCredentials method#5624
piotr-goetz-duco wants to merge 1 commit intoaws:masterfrom
piotr-goetz-duco:credentials-resolve-fix

Conversation

@piotr-goetz-duco
Copy link

Problem - incorrect order of method calls

The handleProfileFileReload(cachedOrRefreshedProfileFile) method should be called before updating the currentProfileFile to ensure that the credentials provider is updated with the new profile file before it is set as the current profile file.

Motivation and Context

#5001
This change ensures that any subsequent calls to resolveCredentials method will use updated credentials provider.

Modifications

Moved the handleProfileFileReload(cachedOrRefreshedProfileFile) call before the currentProfileFile = cachedOrRefreshedProfileFile assignment.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@piotr-goetz-duco piotr-goetz-duco requested a review from a team as a code owner September 25, 2024 13:03
@debora-ito
Copy link
Member

@piotr-goetz-duco I apologize for taking so long to reply here.

We're not sure about this change. We could not reproduce the original issue in #5001, so if you're still experiencing this please open a new Github issue with a self-contained repro code, and we'll take a look.

@debora-ito debora-ito added the closing-soon This issue will close in 4 days unless further comments are made. label Feb 28, 2026
@debora-ito debora-ito self-assigned this Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closing-soon This issue will close in 4 days unless further comments are made.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants