Changed order of method calls in ProfileCredentialsProvider resolveCredentials method#5624
Open
piotr-goetz-duco wants to merge 1 commit intoaws:masterfrom
Open
Changed order of method calls in ProfileCredentialsProvider resolveCredentials method#5624piotr-goetz-duco wants to merge 1 commit intoaws:masterfrom
piotr-goetz-duco wants to merge 1 commit intoaws:masterfrom
Conversation
Member
|
@piotr-goetz-duco I apologize for taking so long to reply here. We're not sure about this change. We could not reproduce the original issue in #5001, so if you're still experiencing this please open a new Github issue with a self-contained repro code, and we'll take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem - incorrect order of method calls
The
handleProfileFileReload(cachedOrRefreshedProfileFile)method should be called before updating thecurrentProfileFileto ensure that the credentials provider is updated with the new profile file before it is set as the current profile file.Motivation and Context
#5001
This change ensures that any subsequent calls to
resolveCredentialsmethod will use updated credentials provider.Modifications
Moved the
handleProfileFileReload(cachedOrRefreshedProfileFile)call before thecurrentProfileFile = cachedOrRefreshedProfileFileassignment.Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License