ANSI escape codes should only be written if writer is a TTY#23
Open
LennartC wants to merge 1 commit intoatomicgo:mainfrom
Open
ANSI escape codes should only be written if writer is a TTY#23LennartC wants to merge 1 commit intoatomicgo:mainfrom
LennartC wants to merge 1 commit intoatomicgo:mainfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
========================================
- Coverage 4.86% 3.12% -1.74%
========================================
Files 6 6
Lines 185 192 +7
========================================
- Hits 9 6 -3
- Misses 176 184 +8
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
Member
|
Hi, thanks for the PR! We should still have a way to force ANSI codes, even if it is a file. Sometimes the user might want to record the ANSI codes to debug a problem, or to validate tests. We should either have something like |
Author
|
Not entirely sure how to fix this then.
Let me know what you prefer and I'll update the PR ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ANSI escape codes should only be written when the
writeris a terminal.This is important when the output is redirect to a file for example.
This would solve #24