Open
Conversation
windows-sys is a frequent source of duplicate dependencies. Widening the range of allowed versions gives downstream crates a fighting chance of being able to select one unique version of it.
All of our dependencies now support windows-sys 0.60. Support for windows-sys 0.60 has been retained as it is the last version to support Rust versions before 1.71, and our MSRV is 1.66.
Update to snapbox v1.0.0
Drop support for windows-sys v0.60
This aligns with the MSRV of windows-sys 0.61.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that windows-sys 0.61 is widely supported in the crates ecosystem, including by all of snapbox's dependencies, it is probably OK to drop support for windows-sys 0.60. This PR also bumps the MSRV to 0.71 to match that of windows-sys 0.61.