Open
Conversation
…dd-dynamic-queues
npauzenga
reviewed
Mar 12, 2026
| } | ||
| output "send_pan_task" { | ||
| value = module.cumulus.send_pan_task | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Sort-of. This work was tested/based off of #235, I just missed it hadn't been merged yet.
I'll clean this up, it's not needed for the main merge.
npauzenga
reviewed
Mar 12, 2026
|
|
||
| ## Unreleased | ||
|
|
||
| * Add dynamic_throttled_queues to allow for throttled queues with configurable names to be defined according to the pattern: https://sqs.${data.aws_region.current.name}.amazonaws.com/${data.aws_caller_identity.current.account_id}/${local.prefix}-${q.queue_name}. This allows for queue configurations to be defined programatically for similar deployments across deployment/account/regions/etc. |
There was a problem hiding this comment.
Dumb question: Are "Throttled Queues" a well-defined thing? I know what you mean. You know what you mean. Do we need to define what we mean?
Collaborator
Author
There was a problem hiding this comment.
It's a fair point - I think in the context of the ecosystem and Cirrus.... probably. We could include a link to the Core docs though, if you think that's helpful.
mattp0
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a way to dynamically configure throttled queues in cases where the same queue is being deployed across multiple deployments and/or accounts rather than redefining the queue per deployment.