Makes a parser error when instance and contract functions aren't full…#291
Open
rodrigogribeiro wants to merge 2 commits intomainfrom
Open
Makes a parser error when instance and contract functions aren't full…#291rodrigogribeiro wants to merge 2 commits intomainfrom
rodrigogribeiro wants to merge 2 commits intomainfrom
Conversation
Collaborator
|
I have two issues with this PR:
Point 1 perhaps may be solved as a part of a much needed general error-message overhaul. Point 2 may be solved by defaulting to One way to do this is in SolcoreParser.y: |
…y type annotated. Signed-off-by: Rodrigo Ribeiro <rodrigogribeiro@gmail.com>
24eecb7 to
1e97116
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves issue #226 by modifying the parser to only accept instance and contract functions which are fully type annotated. Almost all changes are due to make all test cases compile due to the parser change.