Fix --help in nested subcommands with default subcommands#866
Open
stackotter wants to merge 1 commit intoapple:mainfrom
Open
Fix --help in nested subcommands with default subcommands#866stackotter wants to merge 1 commit intoapple:mainfrom
stackotter wants to merge 1 commit intoapple:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue discussed in #865. I updated the implementation of
checkForBuiltInFlags'srequireSoloArgumentparameter to explicitly check for a single input argument rather than a single parsed argument, as some input arguments get parsed into multiple synthetic arguments, for example-help->[-help, -h, -e, -l, -p]. #612 was trying to do this but did it in a bit of a hacky way that introduced #865. I have added a unit test that fails without these changes and succeeds with them.Checklist