[SYNCOPE-1951] - Add realm search base on plain attr#1300
Draft
TatoniMatteo wants to merge 5 commits intoapache:4_0_Xfrom
Draft
[SYNCOPE-1951] - Add realm search base on plain attr#1300TatoniMatteo wants to merge 5 commits intoapache:4_0_Xfrom
TatoniMatteo wants to merge 5 commits intoapache:4_0_Xfrom
Conversation
…ntations, missing neo4j implementation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/RealmServiceImpl.java
Fixed
Show fixed
Hide fixed
...jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/AbstractJPARealmSearchDAO.java
Dismissed
Show dismissed
Hide dismissed
...jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/AbstractJPARealmSearchDAO.java
Dismissed
Show dismissed
Hide dismissed
...jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/AbstractJPARealmSearchDAO.java
Dismissed
Show dismissed
Hide dismissed
...jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/AbstractJPARealmSearchDAO.java
Dismissed
Show dismissed
Hide dismissed
| doReturn(Optional.of(aLong)).when(plainSchemaDAO).findById("aLong"); | ||
| doAnswer(ic -> { | ||
| PlainAttrValue value = ic.getArgument(2); | ||
| value.setLongValue(Long.valueOf(ic.getArgument(1))); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note test
| return new CheckResult<>(schema, attrValue, cond); | ||
| } | ||
|
|
||
| protected CheckResult<AnyCond> check(final AnyCond cond) { |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
| return fillAttrQuery(checked.schema(), checked.value(), cond); | ||
| } | ||
|
|
||
| protected Query getQuery(final AnyCond cond) { |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
| return fillAttrQuery(checked.schema(), checked.value(), checked.cond()); | ||
| } | ||
|
|
||
| protected Query getQueryForCustomConds(final SearchCond cond) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| doReturn(Optional.of(aLong)).when(plainSchemaDAO).findById("aLong"); | ||
| doAnswer(ic -> { | ||
| PlainAttrValue value = ic.getArgument(2); | ||
| value.setLongValue(Long.valueOf(ic.getArgument(1))); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.