[SPARK-56111][CORE] Add SparkContext.isDriver() and use it across the codebase#54922
Open
cloud-fan wants to merge 2 commits intoapache:masterfrom
Open
[SPARK-56111][CORE] Add SparkContext.isDriver() and use it across the codebase#54922cloud-fan wants to merge 2 commits intoapache:masterfrom
cloud-fan wants to merge 2 commits intoapache:masterfrom
Conversation
yaooqinn
approved these changes
Mar 20, 2026
Co-authored-by: Isaac
cloud-fan
changed the title
cloud-fan
changed the title
Contributor
Author
|
cc @Ngone51 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a
SparkContext.isDriver(executorId)utility method and replace all manualexecutorId == SparkContext.DRIVER_IDENTIFIER/executorId != SparkContext.DRIVER_IDENTIFIERchecks across the codebase with it.Why are the changes needed?
The driver-detection pattern
executorId == SparkContext.DRIVER_IDENTIFIERis duplicated in ~20 places across core, SQL, streaming, profiler, and Kubernetes modules. Centralizing it in a single method improves readability and reduces duplication.Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests — this is a pure refactoring with no behavior change.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.6