[SPARK-56007][CONNECT] Fix ArrowDeserializer to use positional binding for rows#54832
Open
hvanhovell wants to merge 4 commits intoapache:masterfrom
Open
[SPARK-56007][CONNECT] Fix ArrowDeserializer to use positional binding for rows#54832hvanhovell wants to merge 4 commits intoapache:masterfrom
hvanhovell wants to merge 4 commits intoapache:masterfrom
Conversation
…g for RowEncoder and validate schema Switch RowEncoder deserialization from name-based lookup to positional binding to correctly handle duplicate column names. Add field-count and field-name mismatch error conditions with new tests. Co-authored-by: Isaac
Co-authored-by: Isaac
Fix the `bind to schema` test: - Correct `wideSchemaEncoder` (remove stray `a: int` field) - Fix narrow schema field order (C before d) and element struct fields (da, db not da, dc) - Supply complete wide-schema input rows (include dc boolean in d elements) - Correct expected output to match narrow schema projection - Add try/finally to ensure both iterators are always closed - Fix `unknown field` to expect `SparkRuntimeException` not `AnalysisException` Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR switches RowEncoder deserialization in the Spark Connect Scala client from name-based lookup to positional binding to correctly handle duplicate column names.
Why are the changes needed?
The Spark Connect Scala client can't handle with rows with duplicate column names. This is regression w.r.t. classic.
Does this PR introduce any user-facing change?
Yes. It fixes a bug.
How was this patch tested?
I added tests to ArrowEncoderSuite.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code v2.1.76