Remove specializations for Docker Engine v28 on Windows Server 2025#37966
Open
linghengqian wants to merge 1 commit intoapache:masterfrom
Open
Remove specializations for Docker Engine v28 on Windows Server 2025#37966linghengqian wants to merge 1 commit intoapache:masterfrom
linghengqian wants to merge 1 commit intoapache:masterfrom
Conversation
c8b81d9 to
36b1dc9
Compare
36b1dc9 to
e7cd026
Compare
There was a problem hiding this comment.
Pull request overview
This pull request removes Docker Engine v28 specializations for Windows Server 2025 following the release of Rancher Desktop v1.22.0 with Docker Engine v29. The PR also fixes GraalVM Native Image test failures caused by class changes and adds a workaround for Presto server clock synchronization issues.
Changes:
- Removed DOCKER_API_VERSION environment variable workaround and added min-api-version to daemon.json for Rancher Desktop configuration
- Cleaned up GraalVM reachability metadata by removing unused Seata and JDBCRepository entries and adding java.lang.Record support
- Added max-tolerate-time-difference-milliseconds configuration for Presto to handle clock backward issues
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/native/src/test/resources/test-native/yaml/jdbc/databases/presto.yaml | Added clock tolerance configuration to prevent Snowflake key generation failures |
| test/native/src/test/resources/test-native/ps1/config-rdctl.ps1 | Updated Rancher Desktop configuration by removing DOCKER_API_VERSION and adding min-api-version |
| infra/reachability-metadata/.../generated-reachability-metadata/reachability-metadata.json | Cleaned up GraalVM metadata: added Record support, removed unused Seata and JDBCRepository entries |
| infra/reachability-metadata/.../HikariCP/4.0.3/reachability-metadata.json | Simplified HikariConfig reflection metadata using allPublicMethods |
| docs/.../graalvm-native-image.en.md | Updated Windows setup documentation to reflect Rancher Desktop v1.22.0 changes |
| docs/.../graalvm-native-image.cn.md | Updated Chinese Windows setup documentation |
| docs/.../development/_index.en.md | Updated Windows development setup instructions |
| docs/.../development/_index.cn.md | Updated Chinese Windows development setup instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #37847 .
Changes proposed in this pull request:
/etc/docker/daemon.jsonnow contains an additional line:"min-api-version": "1.41".max-tolerate-time-difference-millisecondsfororg.apache.shardingsphere.test.natived.jdbc.databases.PrestoTest. I'll be investigating this at Improve GraalVM Reachability Metadata and corresponding nativeTest related unit tests #29052 .Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.