Skip to content

Remove specializations for Docker Engine v28 on Windows Server 2025#37966

Open
linghengqian wants to merge 1 commit intoapache:masterfrom
linghengqian:rancher-bump
Open

Remove specializations for Docker Engine v28 on Windows Server 2025#37966
linghengqian wants to merge 1 commit intoapache:masterfrom
linghengqian:rancher-bump

Conversation

@linghengqian
Copy link
Member

@linghengqian linghengqian commented Feb 5, 2026

For #37847 .

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@linghengqian linghengqian marked this pull request as ready for review February 5, 2026 16:10
@linghengqian linghengqian requested a review from Copilot February 5, 2026 16:10
@linghengqian linghengqian added this to the 5.5.3 milestone Feb 5, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes Docker Engine v28 specializations for Windows Server 2025 following the release of Rancher Desktop v1.22.0 with Docker Engine v29. The PR also fixes GraalVM Native Image test failures caused by class changes and adds a workaround for Presto server clock synchronization issues.

Changes:

  • Removed DOCKER_API_VERSION environment variable workaround and added min-api-version to daemon.json for Rancher Desktop configuration
  • Cleaned up GraalVM reachability metadata by removing unused Seata and JDBCRepository entries and adding java.lang.Record support
  • Added max-tolerate-time-difference-milliseconds configuration for Presto to handle clock backward issues

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/native/src/test/resources/test-native/yaml/jdbc/databases/presto.yaml Added clock tolerance configuration to prevent Snowflake key generation failures
test/native/src/test/resources/test-native/ps1/config-rdctl.ps1 Updated Rancher Desktop configuration by removing DOCKER_API_VERSION and adding min-api-version
infra/reachability-metadata/.../generated-reachability-metadata/reachability-metadata.json Cleaned up GraalVM metadata: added Record support, removed unused Seata and JDBCRepository entries
infra/reachability-metadata/.../HikariCP/4.0.3/reachability-metadata.json Simplified HikariConfig reflection metadata using allPublicMethods
docs/.../graalvm-native-image.en.md Updated Windows setup documentation to reflect Rancher Desktop v1.22.0 changes
docs/.../graalvm-native-image.cn.md Updated Chinese Windows setup documentation
docs/.../development/_index.en.md Updated Windows development setup instructions
docs/.../development/_index.cn.md Updated Chinese Windows development setup instructions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant