[ISSUE #10073] Fix StoreCheckpoint logicsMsgTimestamp to reflect flushed consume queue storetime#10074
Merged
RongtongJin merged 2 commits intoapache:developfrom Feb 5, 2026
Merged
Conversation
…logicsMsgTempTimestamp for in-memory storetime Change-Id: I6085bf6efaef84168ece31d080481717465f2b13
RongtongJin
previously approved these changes
Feb 5, 2026
RongtongJin
reviewed
Feb 5, 2026
store/src/main/java/org/apache/rocketmq/store/StoreCheckpoint.java
Outdated
Show resolved
Hide resolved
Change-Id: Ia65ca06751f765bdc2bf053c58e08789f4b2fb22
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10074 +/- ##
==========================================
Coverage 48.81% 48.82%
Complexity 13336 13336
==========================================
Files 1373 1373
Lines 99877 99883 +6
Branches 12910 12910
==========================================
+ Hits 48756 48768 +12
+ Misses 45190 45183 -7
- Partials 5931 5932 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RongtongJin
approved these changes
Feb 5, 2026
dingshuangxi888
pushed a commit
to dingshuangxi888/rocketmq
that referenced
this pull request
Feb 10, 2026
…t flushed consume queue storetime (apache#10074) * Fix StoreCheckpoint: set logicsMsgTimestamp only after CQ flush, use logicsMsgTempTimestamp for in-memory storetime Change-Id: I6085bf6efaef84168ece31d080481717465f2b13 * rename to tmpLogicsMsgTimestamp Change-Id: Ia65ca06751f765bdc2bf053c58e08789f4b2fb22 --------- Co-authored-by: guyinyou <guyinyou.gyy@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…logicsMsgTempTimestamp for in-memory storetime
Change-Id: I6085bf6efaef84168ece31d080481717465f2b13
Which Issue(s) This PR Fixes
Fixes #10073
Brief Description
How Did You Test This Change?